Skip to content

Commit

Permalink
Use compatible sqlite3 version in test application
Browse files Browse the repository at this point in the history
Currently, the `sqlite3` in `Gemfile` generated by `rails new` is not
compatible with Rails.

To solve this issue, modified it to use compatible `sqlite3` using
template.
Ref: rails/rails#35161
  • Loading branch information
y-yagi authored and composerinteralia committed Feb 6, 2019
1 parent df44185 commit e650992
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion features/fixture_replacement_config.feature
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Feature:
I would like the Factory Bot Rails gem to configure Factory Bot as the fixture replacement.

Background:
Given I successfully run `bundle exec rails new testapp`
Given I successfully run `bundle exec rails new testapp -m ../../features/support/rails_template`
And I cd to "testapp"
And I add "factory_bot_rails" from this project as a dependency

Expand Down
2 changes: 1 addition & 1 deletion features/generators.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Feature:
I would like to use factory_bot_rails generators.

Background:
Given I successfully run `bundle exec rails new testapp`
Given I successfully run `bundle exec rails new testapp -m ../../features/support/rails_template`
And I cd to "testapp"
And I add "factory_bot_rails" from this project as a dependency
And I run `bundle install` with a clean environment
Expand Down
2 changes: 1 addition & 1 deletion features/load_definitions.feature
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Feature: automatically load factory definitions

Background:
When I successfully run `bundle exec rails new testapp`
When I successfully run `bundle exec rails new testapp -m ../../features/support/rails_template`
And I cd to "testapp"
And I add "factory_bot_rails" from this project as a dependency
And I add "test-unit" as a dependency
Expand Down
1 change: 1 addition & 0 deletions features/support/rails_template
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"'

0 comments on commit e650992

Please sign in to comment.