Skip to content

Commit

Permalink
Updating readme and contribution guidelines with links to GitHub Issues
Browse files Browse the repository at this point in the history
  • Loading branch information
qrush committed Jun 10, 2009
1 parent 964dd5e commit b92412a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions CONTRIBUTION_GUIDELINES.rdoc
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
We're using GitHub[http://github.com/thoughtbot/factory_girl/tree/master] and Lighthouse[http://thoughtbot.lighthouseapp.com/projects/14354], and we've been getting any combination of github pull requests, Lighthouse tickets, patches, emails, etc. We need to normalize this workflow to make sure we don't miss any fixes.
We're using GitHub[http://github.com/thoughtbot/factory_girl/tree/master], and we've been getting any combination of github pull requests, patches, emails, etc. We need to normalize this workflow to make sure we don't miss any fixes.

* Make sure you're accessing the source from the {official repository}[http://github.com/thoughtbot/factory_girl/tree/master].
* We prefer git branches over patches, but we can take either.
* If you're using git, please make a branch for each separate contribution. We can cherry pick your commits, but pulling from a branch is easier.
* Please make a branch for each separate contribution. We can cherry pick your commits, but pulling from a branch is easier.
* If you're submitting patches, please cut each fix or feature into a separate patch.
* There should be a Lighthouse[http://thoughtbot.lighthouseapp.com/projects/14354] ticket for any submission. If you've found a bug and want to fix it, open a new ticket at the same time.
* Please <b>don't send pull requests</b> Just update the lighthouse ticket with the url for your fix (or attach the patch) when it's ready. The github pull requests pretty much get dropped on the floor until someone with commit rights notices them in the mailbox.
* There should be an issue[http://github.com/thoughtbot/factory_girl/issues] for any submission. If you've found a bug and want to fix it, open a new ticket at the same time.
* Please <b>don't send pull requests</b> Just update the issue with the url for your fix when it's ready. The github pull requests pretty much get dropped on the floor until someone with commit rights notices them in the mailbox.
* Contributions without tests won't be accepted.
* Please don't submit patches or branches that update the Gem version.
2 changes: 1 addition & 1 deletion README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ factory_girl rdoc: http://rdoc.info/projects/thoughtbot/factory_girl

Mailing list: http://groups.google.com/group/factory_girl

factory_girl tickets: http://thoughtbot.lighthouseapp.com/projects/14354-factory_girl
factory_girl issues: http://github.com/thoughtbot/factory_girl/issues

== Contributing

Expand Down

0 comments on commit b92412a

Please sign in to comment.