Add page_description helper, refactor internals #47
Conversation
| module Flutie | ||
| module ViewHelper | ||
| def body_class(options = {}) | ||
| extra_body_classes_symbol = options[:extra_body_classes_symbol] || :extra_body_classes |
There was a problem hiding this comment.
Did you mean options[:extra_body_classes_symbol] || options[:extra_body_classes]? If not, then fetch would be a good candidate here.
|
This is great! 👍 |
|
Looks good to me. I definitely like that page_title and page_description are stored in i18n. |
* Use isolated testing style, not dummy app in spec suite. * Add `page_description` helper similar to `page_title`. * Refactor internals to have a single `Flutie::ViewHelper`. * Have `page_title` and `page_description` use i18n keys instead of `content_for`. * Document changes.
|
/cc @mjankowski |
|
|
||
| <title>Appname : page title</title> | ||
| By default, Flutie will create empty tags: |
There was a problem hiding this comment.
I'd have to look at the HTML spec, but I believe that the title element cannot be empty.
I realize the intention of flutie is to have a reasonable default and assume that the user would override the default, but it seems weird to generate invalid html by default.
That was part of the motivation of the previous impl using the Rails app name (which, granted, is usually not a good page title, but was the least bad thing I could think of).
page_descriptionhelper similar topage_title.Flutie::ViewHelper.page_titleandpage_descriptionuse i18n keys instead ofcontent_for.This is basically a complete rewrite and would introduce breaking changes for the
page_titlehelper. I imagine we'd release a 3.0.0 version.