Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicity sets #4

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Explicity sets #4

merged 1 commit into from
Nov 26, 2023

Conversation

jho406
Copy link
Contributor

@jho406 jho406 commented Nov 24, 2023 •
edited 

Make attribute setting explicit.

With prop_template removing implicit conversations using camelize(:lower), this
commit makes the key formatting the responsibility of form_props. To do this,
we keep a mapping of html attributes => React attributes as provided by React,
and introduce our own with certain options that are needed for frontend components
like `include_hidden`.

The mapping is used right before we pass the keys to prop_template.

@jho406 jho406 force-pushed the explicity-sets branch 2 times, most recently from 6180437 to 4ce9542 Compare November 24, 2023 17:53
@jho406
Make attribute setting explicit.
4cad252 
With prop_template removing implicit conversations using camelize(:lower), this
commit makes the key formatting the responsibility of form_props. To do this,
we keep a mapping of html attributes => React attributes as provided by React,
and introduce our own with certain options that are needed for frontend components
like `include_hidden`.

The mapping is used right before we pass the keys to prop_template.
@jho406 jho406 merged commit 2f11d0c into main Nov 26, 2023
6 checks passed
jho406 added a commit that referenced this pull request Nov 26, 2023
@jho406
Make attribute setting explicit. (#4)
2c5ebd0 
With prop_template removing implicit conversations using camelize(:lower), this
commit makes the key formatting the responsibility of form_props. To do this,
we keep a mapping of html attributes => React attributes as provided by React,
and introduce our own with certain options that are needed for frontend components
like `include_hidden`.

The mapping is used right before we pass the keys to prop_template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jho406