Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving to the normalized format #13

Closed
scsmith opened this issue Mar 16, 2017 · 4 comments
Closed

Consider moving to the normalized format #13

scsmith opened this issue Mar 16, 2017 · 4 comments
Assignees
@dominicsayers
Labels
enhancement
Milestone
v1.1

Comments

@scsmith
Copy link
Collaborator

scsmith commented Mar 16, 2017

The normalized format was added to CloudMailin to make applications like griddler slightly easier. The format makes sure that all headers are lower-cased and deals with arrays in a more generic way.

It might be worth updating the gem to follow these practices as it will make sure less oddities like envelope['To'].

Thoughts?
@dominicsayers
Copy link
Contributor

Is there some documentation of this format on the Cloudmailin site?

@scsmith
Copy link
Collaborator Author

scsmith commented Mar 16, 2017

Not yet, but there needs to be. I'll look at getting this sorted ASAP.

@dominicsayers dominicsayers added this to the v1.1 milestone Mar 16, 2017
dominicsayers added a commit that referenced this issue Mar 17, 2017
@dominicsayers
Use syntax compatible with Ruby 1.9. Closes #13
d1ee163
@dominicsayers
Copy link
Contributor

Can you review PR#20 to check I've got it right?

@dominicsayers
Copy link
Contributor

@scsmith Now we can release the gem to Rubygems, I'd like to get this merged

@dominicsayers dominicsayers self-assigned this Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominicsayers dominicsayers

Labels
enhancement
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@dominicsayers @scsmith