New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter specific configuration #225
Comments
If I understand your first bullet point correctly, then this line changes from processor_class.new(email).public_send(processor_method) to if extra_configuration?
processor_class.new(email, extra_configuration).public_send(processor_method)
else
processor_class.new(email).public_send(processor_method)
end (I added the |
Ya, that's what I meant. We can also check the arity of |
Yes, good point. I like that idea better, since as you point out, this is a breaking change. |
Would love to see this merged! I ran into the exact issue @wingrunr21 describes - we need to be able to configure SPF checking in griddler-mandrill. In the mean time we will probably need to maintain our own fork of the adapter gem. |
@micahbf agreed, I need to get back on getting this change pushed out. I'm a bit swamped right now but I will try and find time. |
@wingrunr21 Let me know if I can help. |
Wanted to open an issue on this before putting together a PR.
I've got a use case where a user would like a configuration option for the Mandrill adapter (see wingrunr21/griddler-mandrill#23). Right now I am considering three approaches:
adapter_config
attribute toGridder::Configuration
which is passed intonew
inGriddler::EmailsController
. Theadapter_config
would be an arbitrary hash that the adapter would then consume as needed (in my case configuring SPF checks).email_service
config option to accept an optional hash of additional configuration. The rest would function like theadapter_config
Any thoughts on this?
The text was updated successfully, but these errors were encountered: