Raise routing errors for invalid or empty page ids #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,13 @@ def clean_path | |||
| end | |||
|
|
|||
| def clean_id | |||
| @page_id.tr("^#{VALID_CHARACTERS}", '') | |||
| @page_id.tr("^#{VALID_CHARACTERS}", '').tap do |id| | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Thanks for the pr @prydonius. Sorry for the delay. Would you mind updating to handle the style issues Hound commented on? Thanks! |
prydonius
force-pushed
the
invalid-page-id
branch
from
7c28ee4
to
d24cf18
Compare
| before { get :show, :id => 'exists' } | ||
| context "using default configuration" do | ||
| describe "on GET to /pages/exists" do | ||
| before { get :show, :id => "exists" } |
|
No worries, @dgalarza! Rebased and fixed the style issues. |
| @@ -31,7 +31,13 @@ def clean_path | |||
| end | |||
|
|
|||
| def clean_id | |||
| @page_id.tr("^#{VALID_CHARACTERS}", '') | |||
| @page_id.tr("^#{VALID_CHARACTERS}", "").tap do |id| | |||
| unless id.length > 0 | |||
|
Thanks for the update @prydonius. Do you feel comfortable rebasing and squashing to prep for a merge. |
prydonius
force-pushed
the
invalid-page-id
branch
from
aec0915
to
9929234
Compare
|
@dgalarza is this ready to be merged in now? |
dgalarza
added a commit
that referenced
this pull request
Feb 19, 2015
Raise routing errors for invalid or empty page ids
|
👍 thanks for the contribution @prydonius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visiting page_ids made entirely up of invalid characters gets sanitised into an empty string, so it looks for a template called "pages/". This raises a missing template error (because it doesn't match the regex checking that it isn't a missing partial).
This commit adds a check to see if the page_id is empty after sanitisation, and raises and error if it is -- which is caught and turned into a routing error.