Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint scss/css linting #1037

Closed
ismay opened this issue Jan 19, 2016 · 11 comments · Fixed by #1334
Closed

Add stylelint scss/css linting #1037

ismay opened this issue Jan 19, 2016 · 11 comments · Fixed by #1334

Comments

@ismay
Copy link

ismay commented Jan 19, 2016

Stylelint is a linter powered by postcss, that can lint css as well as scss. It's kind of like the eslint of css linters, combining both style checks and error checks, and is completely modular (just like eslint). Since a lot of people are moving to postcss, I think this would be a nice addition to the list of hound linters.

@teoljungberg
Copy link
Contributor

Thanks for reporting this. We have been talking with the creators of https://github.com/sasstools/sass-lint/ about replacing the current scss-lint with that.

We'll add this into the weighing process too

@ismay
Copy link
Author

ismay commented Jan 19, 2016

👍 Cool, sounds good. I'd be really excited with the option of using postcss, the guys behind that project are putting a lot of effort into it and it should be just as easy to use for scss linting.

Thanks for considering it!

@davidtheclark
Copy link

@teoljungberg If you do consider stylelint, I'd appreciate any feedback you feel like providing, whether or not you decide to use it. Thanks.

@leandrogrillo
Copy link

any news about it? :(

@IschaGast
Copy link

IschaGast commented Jul 25, 2016

Would be really nice to have this

@ryanlindsey
Copy link

ryanlindsey commented Dec 15, 2016

@teoljungberg I'm very interested in stylelint support, this is the only thing holding me back from integrating Hound on a few projects.

@kaelig
Copy link

kaelig commented Jan 27, 2017

We'd be super interested in support for stylelint as well.

@athyuttamre
Copy link

+1. Perhaps one of the maintainers can lay out what needs to be changed, and one of us could send in a PR?

@kaelig
Copy link

kaelig commented Mar 10, 2017

Sorry to pull that card out but we're going to have to switch to another service to get stylelint support.

@gylaz
Copy link
Member

gylaz commented Mar 10, 2017

@athyuttamre A PR would be welcome! Here are most recent commits that add Reek as a linter to Hound:

4852cc9
and
https://github.com/houndci/linters/commit/e382859cd19df79c7e73da2f980bde522a4c0cfb

Additionally, you can see how SCSSLint is implemented in this repo and in the hound/linters repo: https://github.com/houndci/linters/tree/master/lib/linters/scss_lint

@athyuttamre
Copy link

Thanks for doing this @blackjid and @gylaz! It's very much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants