Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

Requesting code review for week 1 intermediate-rails exercise #1

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Requesting code review for week 1 intermediate-rails exercise #1

wants to merge 39 commits into from

Conversation

SamSamskies
Copy link

Could I get an overall code review? e.g. Comments on my commit messages, the way I installed and used Twitter Bootstrap, etc.

Specific responsive design Bootstrap questions:

  • How I can prevent the text in my shouts container from popping out into a new row when I shrink the screen width?
  • How can I prevent the top nav height from increasing when I shrink the screen width?

Thanks!

@SamSamskies
Generate skeleton for Shouter app.
c41c618
@SamSamskies
Remove default Rails index page.
c34e5a7
@SamSamskies
Add some basic gems to aid development and produce an MVP.
140398a
@SamSamskies
Create landing page.
8eeb81c
@SamSamskies
Install Monban scaffold.
22be1cd 
Monban is a gem used for basic user authentication.
@SamSamskies
Add links to default Monban login, sign up and sign out pages.
8f4a8a3
@SamSamskies
Turn off Whitelist mode because we are using strong parameters.
86f0dd6
@SamSamskies
Add username attribute to User.
5486f9d
@SamSamskies
Create initializer to include ForbiddenAttributesProtection in models.
e2a39c9
@SamSamskies
Redirect user to dashboard upon login.
b62002b
@SamSamskies
Setup backend Shout functionality.
7132694
@SamSamskies
Ignore .DS_Store files.
e0ca3e0
@SamSamskies
Add basic shout functionality.
7377f1d
@SamSamskies
Link to show pages for individual shouts.
cc87067
@SamSamskies
Link to user pages which displays all of their shouts.
6ddbc9b
@SamSamskies
Install GroundworkCSS framework to help with styling.
ce7c5b9
@SamSamskies
Remove GroundworkCSS framework.
5dcb597
@SamSamskies
Install Twitter Bootstrap.
ebfaeeb
@SamSamskies
Style dashboard and top nav a little with Twitter Bootstrap.
1d6ecf5
@SamSamskies
Pull Gravatar image of user and display with shouts.
093c9e5
@SamSamskies
Fix thumbnail blowing up bug when screen width is mobile size.
71daa2d
@SamSamskies
Add site title home link in top nav.
9550ed6
@SamSamskies
Make user thumbnail in shout body link to user profile.
786a8ae
@SamSamskies
Style user profile page optimized for mobile.
ffc9646
@SamSamskies
Optimize style on shout page for mobile.
1670a17
@SamSamskies
Using Twitter Bootstrap so top nav CSS not needed anymore.
3f072ec
@SamSamskies
Make Shouts polymorphic.
9064944 
Still need to implement photo content type of shout.
@SamSamskies
User can post a photo as a shout.
11553d8 
Use Paperclip gem for to manage image uploading.
@SamSamskies
Link image to full size image.
dc51b09
@SamSamskies
User's can now choose people to follow.
049cd2e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SamSamskies