Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gpg-suite Mail.app plugin #532

Closed
wants to merge 2 commits into from

Conversation

ckundo
Copy link

@ckundo ckundo commented May 14, 2018

[Closes #531]

@derekprior
Copy link
Contributor

This would break the asdf install of nodejs which attempts to verify the package signatures. We can disable this check when installing nodejs, but then any future installs of nodejs would need to know to do this.

Another alternative would be to rm /Library/Mail/Bundles/GPGMail.mailbundle

@ckundo
Copy link
Author

ckundo commented May 14, 2018

@derekprior from what I can tell, the asdf node installation uses gpg cli, which doesn't require the entire gpg-suite installation. I think just brew install gpg2 would work.

https://github.com/asdf-vm/asdf-nodejs/blob/7edd9d6b9a04d2eef8aeeb9c8d9fe038d07f57a4/bin/install#L165

Edit: brew install gpg2 alone is not enough, looks like the keyservers are not configured on install.

@georgebrock
Copy link

If I've understood the vulnerabilities correctly, they require the message to not only be decrypted but also rendered in a mail agent that downloads images, styles, etc. by default.

Seems like Derek's proposed solution (rm …/GPGMail.mailbundle) would mitigate that, without needing to remove the whole of the GPG suite.

See https://efail.de/ for more.

@ckundo ckundo changed the title Remove gpg-suite Remove gpg-suite Mail.app plugin May 16, 2018
@cpytel cpytel deleted the branch thoughtbot:master March 30, 2022 16:49
@cpytel cpytel closed this Mar 30, 2022
@cpytel cpytel mentioned this pull request Mar 30, 2022
@cpytel
Copy link
Member

cpytel commented Mar 30, 2022

This PR was made against master, so I needed to recreate it. I also wanted to test it on a fresh install of macOS Monterey. While searching, I found an alternative brew package which does not install the mail extension and I opened a PR for that instead #607

@ckundo
Copy link
Author

ckundo commented Mar 30, 2022

thanks @cpytel sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants