Return error code for failure sourcing asdf.sh #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpytel
force-pushed
the
source-exit-code
branch
2 times, most recently
from
cc489e5
to
7b98541
Compare
source (or `.`) is a built in command and as a result it halts script execution, and the error code from the command is not returned. This resulted in the exit code of the script in this case being `0` rather than the error code of the source command, which is 127 (command not found).
cpytel
force-pushed
the
source-exit-code
branch
from
7b98541
to
3f16c31
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source (or
.) is a built in command and as a result it halts scriptexecution, and the error code from the command is not returned. This
resulted in the exit code of the script in this case being
0ratherthan the error code of the source command, which is 127 (command not
found).