apply convert_options before transformation

[jotto]

When calling the convert command from the Thumbnail processor's make method, does it make more sense to place the convert_options before the transformation command?

call the resize at the end

convert ':SOURCE_PATH' -strip -fuzz 1% -bordercolor white -border 1x1 -trim -repage -1-1 -resize "100x100" ':DEST_PATH'

instead of calling resize at the beginning

convert ':SOURCE_PATH' -resize "100x100" -strip -fuzz 1% -bordercolor white -border 1x1 -trim -repage -1-1 ':DEST_PATH'

because some of the convert_options may change the image size, therefore leaving you with a different size than you specified in the geometry.

[jyurek]

I think this is a condition where we'd need options in 3 places: Before the source file, between source file and transformation, and after transformation. But if you need that level of control over this, it might be better to write a Processor instead. But I think the current implementation is acceptable for most applications. I'd be willing to entertain pull requests to this effect, though.

[rterbush]

FWIW, I'm digging through the git trying to figure out how to do exactly this. A -trim flag after a -resize does nothing. Needs to be trimmed before resized.

[jotto]

@rterbush here's my quick monkey patching hack, inside application.rb for paperclip 3.3.1 https://gist.github.com/jotto/5256221

[rterbush]

Thanks @jotto that looks like it will do the trick.

Randy

On Wed, Mar 27, 2013 at 11:23 AM, Jonathan Otto notifications@github.comwrote:

@rterbush https://github.com/rterbush here's my quick monkey patching
hack, inside application.rb for paperclip 3.3.1
https://gist.github.com/jotto/5256221

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1085#issuecomment-15537981
.