This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Remove Tempfile tests from Thumbnail spec #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you think we should move over those specs to a |
houndci-bot
reviewed
Nov 14, 2016
| @@ -0,0 +1,35 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
That test PR needs more work than I can put in now, and this PR is ready. Merging. Thank you! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Up
Was browsing the paperclip test suite and noticed that the
thumbnail_spechad a few tests from a while back that did not belong - they were testingPaperclip::Tempfileinstead.What This Does
This PR removes those tests.