This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Include Cocaine error when there was an error processing thumbnails #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 29, 2017
spec/paperclip/thumbnail_spec.rb
Outdated
| @thumb.make | ||
| end | ||
| }.to raise_error Paperclip::Error, /unrecognized option `-this-aint-no-option'/ |
| assert_raises(Paperclip::Error) do | ||
| silence_stream(STDERR) do | ||
| silence_stream(STDERR) do | ||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
There was a problem hiding this comment.
Hmm. A continual conundrum for me.
expect do
blah
end.to raise_errorI think I prefer {...}, but what's your opinion?
lib/paperclip/thumbnail.rb
Outdated
| @@ -78,7 +78,10 @@ def make | |||
|
|
|||
| success = convert(parameters, :source => "#{File.expand_path(src.path)}#{'[0]' unless animated?}", :dest => File.expand_path(dst.path)) | |||
| rescue Cocaine::ExitStatusError => e | |||
| raise Paperclip::Error, "There was an error processing the thumbnail for #{@basename}" if @whiny | |||
| if @whiny | |||
| message = "There was an error processing the thumbnail for #{@basename}:\n" + e.message | |||
There was a problem hiding this comment.
I think I prefer a long line here, but I'm happy to split it.
houndci-bot
reviewed
May 7, 2018
| assert_raises(Paperclip::Error) do | ||
| silence_stream(STDERR) do | ||
| silence_stream(STDERR) do | ||
| expect { |
There was a problem hiding this comment.
Style/BlockDelimiters: Avoid using {...} for multi-line blocks.
| @@ -85,7 +85,10 @@ def make | |||
| dest: File.expand_path(dst.path), | |||
| ) | |||
| rescue Terrapin::ExitStatusError => e | |||
| raise Paperclip::Error, "There was an error processing the thumbnail for #{@basename}" if @whiny | |||
| if @whiny | |||
| message = "There was an error processing the thumbnail for #{@basename}:\n" + e.message | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [97/80]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been occasionally seeing errors in production telling us "There was an error processing the thumbnail". Unfortunately, Paperclip doesn't currently tell us what was ImageMagick was complaining about, so we weren't able to debug further what was going on.
This PR ensures that the original error message from Cocaine (and therefore ImageMagick) is included in the Paperclip error (when
whinymode is on), which allowed us to identify the problem with our ImageMagick configuration.