Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Prevents a file name from becoming blank when :restricted_characters => nil #762

Closed
wants to merge 1 commit into from

Conversation

nuna
Copy link

@nuna nuna commented Mar 1, 2012

cleanup_filename return nil when :restricted_characters is nil.

(I think that passing nil means `not restricted'.)

@sikachu
Copy link
Contributor

sikachu commented Mar 1, 2012

Do we have a test case covering when :restricted_characters is nil? If not, do you mind adding the test, amend your commit, and force push to your branch?

Thank you.

@jyurek
Copy link

jyurek commented Apr 13, 2012

Even if all characters are restticted, the filename will remain _ and so won't be empty. Are you seeing other behavior? Also, we'll need a test case, as @sikachu said. Thanks.

@sikachu sikachu closed this in a6c8683 May 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants