Remove virtual_path_of_template. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was originally created to more easily tie a page json with a page component. It was to be used as the componentIdentifier. A better and more maintainable approach would be to use a combination of `controller_path` and `action` for the `componentIdentifier`. This removes the hacky-ness of dynamically defining a method, while giving flexibility as two controller actions can render the same template while having a different componentIdentifier.
jho406
added a commit
that referenced
this pull request
Dec 10, 2023
* Revert "Remove virtual_path_of_template. (#12)" This reverts commit 55ace47. * Expose method to all templates After the revert, we'd like to rename the method and make it accessible to all templates. The reasoning behind this is because superglue was using @virtual_path on the html templates, which seemed like a private variable, with this change we expose the active_template_virtual_path to everyone so we don't have to use private instance vars elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was originally created to more easily tie a page json with a page component. It was to be used as the componentIdentifier.
A better and more maintainable approach would be to use a combination of
controller_pathandactionfor thecomponentIdentifier. This removes the hacky-ness of dynamically defining a method, while giving flexibility as two controller actions can render the same template while having a different componentIdentifier.