Skip to content
This repository has been archived by the owner on Mar 2, 2018. It is now read-only.

Any Navigation Refills? #435

Closed
bgarrant opened this issue Mar 30, 2017 · 5 comments
Closed

Any Navigation Refills? #435

bgarrant opened this issue Mar 30, 2017 · 5 comments

Comments

@bgarrant
Copy link

I know you are all working on a new Refills to work with latest Neat and Bourbon, but do you have any plans for a Navigation Refill like you had previously? I am using the latest versions of Neat and Bourbon 4.3.3 and I am searching for a navbar component like you had before. Do you have anything that will work with latest versions, or can you advise how to make the old one work? It seems it is just missing a couple variables like $horizontal-bar-mode:.

http://refills.bourbon.io/#er-toc-id-13

@creuter
Copy link
Contributor

creuter commented Mar 30, 2017

We aren't currently planning to rebuild the navigation refill. We'll instead be focusing on smaller components that aren't so opinionated about how they're composed.

In the linked scss, $horizontal-bar-mode is defined as $large-screen, which is defined above that as $large-screen: 53.75em !default;. So those variables are there, and that doesn't appear to the problem.

It's more likely that you don't have the media function since upgrading your version of Neat. You can instead use the normal syntax for a media query:

@media screen and (min-width: $horizontal-bar-mode) {
  ...
}

or you could dig into the new grid-media function in Neat 2.0.0.

The next version of Refills will no longer depend on Neat, to remove these types of inconsistencies.

@bgarrant
Copy link
Author

Sounds great. I will try that. Thanks.

@bgarrant
Copy link
Author

Is there anything wrong with using that navigation refill as far as functions or browser compatibility? Just curious before I use it.

@creuter
Copy link
Contributor

creuter commented Mar 30, 2017

A lot of the implementation details could be argued, but the resulting markup and styling are fine, and should work in all modern browsers.

@bgarrant
Copy link
Author

Thanks so much. Do you have any other suggestions of a more up-to-date responsive navigation script with dropdowns? Anything you can suggest?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants