allow_value matcher ignores some values

[indrekj]

e.g

validating_format(:with => /abc/).
  should_not allow_value('bcd', 'abc').for(:attr)

This assertion should fail because 'abc' is allowed value, but it doesn't.

[mxie]

@indrekj Thanks for putting in this issue! However, this is actually the expected behavior (and in our docs too), i.e. allow_value (when giving multiple values) will fail as soon as it finds a bad one. All others will be ignored/unprocessed.

Closing.

[indrekj]

Basically, I should never use should_not allow_value(..) with multiple values? I find it a bit odd because should allow_value(...) with multiple values works correctly.

[mxie]

@indrekj Sorry, I'm getting a little confused now. You can definitely use should_not allow_value(..) with multiple values. It's just that if any of those values are not allowed, then its test will fail.

[indrekj]

That's the problem. See my initial example. It clearly should fail because of the second value, but it doesn't.

[drapergeek]

@indrekj The problem is that it 'does not' allow the value of 'bcd'. With that single failure, the entire set is rendered as a 'failure' and therefore the test passed. I realize this is a bit confusing but I would recommend splitting your allow values into multiple assertions in this case. The 'should_not' case can get a bit confusing.

[JanDintel]

@mxie I suggest to reconsider this issue, the current implementation is counter intuitive for the #should_not. See the different issues #175, #197 and my comment on pull request #347