Fix deprecation warning for uniqueness matcher (Rails 4.2) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 24, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - shoul...
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/VariableName has the wrong namespace - should be Naming .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AlignArray has the wrong namespace - should be Layout .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/BlockEndNewline has the wrong namespace - should be Layout .rubocop.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ConstantName has the wrong namespace - should be Naming .rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout .rubocop.yml: Style/EndOfLine has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout .rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineBlockLayout has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterMethodName has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterNot has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComment has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideRangeLiteral has the wrong namespace - should be Layout .rubocop.yml: Style/Tab has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
The uniqueness matcher needs to set the attributes under test (which is not only the attribute you give to the matcher, but also any scope attributes as well) to arbitrary values so that it can test the underlying uniqueness validation logic. To set an attribute correctly, it needs to check what type of column that attribute is and then generate a value that matches the column (otherwise unpredictable results happen). The matcher was doing this for scope attributes, but not for the main attribute. One of the consequences of this inconsistency is that when setting a boolean attribute, it was using a string value, which generates a warning under Rails 4.2. This commit fixes this so that the main attribute is set the same way as scope attributes, thereby removing the warning.
mcmire
force-pushed
the
fix-deprecation-warning-for-uniqueness
branch
from
0b40e0e
to
9103ead
Compare
houndci-bot
reviewed
Jan 24, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - shoul...
.rubocop.yml: Style/AccessModifierIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/AlignHash has the wrong namespace - should be Layout .rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout .rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLineBetweenDefs has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundBlockBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundClassBody has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundModuleBody has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/FirstParameterIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/MultilineMethodCallIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/SpaceAroundBlockParameters has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundEqualsInParameterDefault has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout .rubocop.yml: Style/VariableName has the wrong namespace - should be Naming .rubocop.yml: Style/ExtraSpacing has the wrong namespace - should be Layout .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AlignArray has the wrong namespace - should be Layout .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/BlockEndNewline has the wrong namespace - should be Layout .rubocop.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming .rubocop.yml: Style/CommentIndentation has the wrong namespace - should be Layout .rubocop.yml: Style/ConstantName has the wrong namespace - should be Naming .rubocop.yml: Style/ElseAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundAccessModifier has the wrong namespace - should be Layout .rubocop.yml: Style/EmptyLinesAroundMethodBody has the wrong namespace - should be Layout .rubocop.yml: Style/EndOfLine has the wrong namespace - should be Layout .rubocop.yml: Style/IndentationConsistency has the wrong namespace - should be Layout .rubocop.yml: Style/IndentArray has the wrong namespace - should be Layout .rubocop.yml: Style/LeadingCommentSpace has the wrong namespace - should be Layout .rubocop.yml: Style/MultilineBlockLayout has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeFirstArg has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterColon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundKeyword has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterMethodName has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterNot has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAfterSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComma has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeComment has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceBeforeSemicolon has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceAroundOperators has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideBrackets has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideParens has the wrong namespace - should be Layout .rubocop.yml: Style/SpaceInsideRangeLiteral has the wrong namespace - should be Layout .rubocop.yml: Style/Tab has the wrong namespace - should be Layout .rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The uniqueness matcher needs to set the attributes under test (which is
not only the attribute you give to the matcher, but also any scope
attributes as well) to arbitrary values so that it can test the
underlying uniqueness validation logic. To set an attribute correctly,
it needs to check what type of column that attribute is and then
generate a value that matches the column (otherwise unpredictable
results happen). The matcher was doing this for scope attributes, but
not for the main attribute. One of the consequences of this
inconsistency is that when setting a boolean attribute, it was using a
string value, which generates a warning under Rails 4.2.
This commit fixes this so that the main attribute is set the same way as
scope attributes, thereby removing the warning.
This fixes #949.