Don't include setup script in global executables #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the files in `bin/` were included in the list of executables in the gemspec. This is Very Bad and means that `setup` was getting installed as a global executable when a user installed the gem on their computer. To fix this, I've done an audit and removed all extraneous files from the installed gem. It should now only include: * `docs` * `lib` * `MIT-LICENSE` * `README.md` * `shoulda-matchers.gemspec`
Closed
Closed
pearlzhuzeng
added a commit
to galahq/gala
that referenced
this pull request
Feb 28, 2019
4.0.0 was yanked: thoughtbot/shoulda-matchers#1180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the files in
bin/were included in the list of executables inthe gemspec. This is Very Bad and means that
setupwas gettinginstalled as a global executable when a user installed the gem on their
computer.
To fix this, I've done an audit and removed all extraneous files from
the installed gem. It should now only include:
docslibMIT-LICENSEREADME.mdshoulda-matchers.gemspec