validate_presence_of(:active_storage_field) throws exception #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to test validation of presence against a active storage relation, shoulda tries to set the attribute as empty string. This makes the association fail to be set and breaks the test. I've introduced a block that checks if the field is an active storage relation and only allows `nil` to be set to the object. Fixes thoughtbot#1223
mcmire
requested changes
Jul 6, 2019
lib/shoulda/matchers/active_model/validate_presence_of_matcher.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_model/validate_presence_of_matcher_spec.rb
Outdated
Show resolved
Hide resolved
|
@mcmire I'll wait on your reply to item 1 and push the fixes :) |
Improve readability of code.
gmmcal
deleted the
issue-1223-validate_presence_of-active_storage-field-throws-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to test validation of presence against a active storage relation, shoulda tries to set the attribute as empty string. This makes the association fail to be set and breaks the test.
I've introduced a block that checks if the field is an active storage relation and only allows
nilto be set to the object.Fixes #1223