Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presence matcher against an AM record #1231

Merged
merged 4 commits into from
Jul 9, 2019
Merged

Fix presence matcher against an AM record #1231

merged 4 commits into from
Jul 9, 2019

Commits on Jul 9, 2019

  1. Turn off more Rubocop checks

    @mcmire
    mcmire committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    34020fb View commit details
    Browse the repository at this point in the history

  2. Fix negative version of presence matcher

    @mcmire
    mcmire committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ba9dbff View commit details
    Browse the repository at this point in the history

  3. Slightly refactor presence matcher 

    ...in preparation for detecting models that support the full Attributes
API more closely.
    @mcmire
    mcmire committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    6ff9f17 View commit details
    Browse the repository at this point in the history

  4. Fix presence matcher against an AM record 

    When using the presence matcher against an ActiveModel record, check to
ensure that the model is using the Attributes API and has explicitly
declared the attribute to be a string before attempting to set the
attribute to an empty string. Otherwise, the attribute may be getting
treated as an object in some point in the validation process, and
therefore setting it to an empty string would create problems.
    @mcmire
    mcmire committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    b3025dc View commit details
    Browse the repository at this point in the history