Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appraisal command in CONTRIBUTING.md file #1253

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix appraisal command in CONTRIBUTING.md file #1253

merged 1 commit into from
Nov 19, 2019

Conversation

vsppedro
Copy link
Collaborator

@vsppedro vsppedro commented Nov 19, 2019

Hello, I was following the CONTRIBUTING.md file.

At some point it suggest to run this command:

bundle exec appraisal 5.2 rspec spec/unit/shoulda/matchers/active_model/validate_inclusion_of_matcher_spec.rb

But instead of running the tests, it returned:

bundler: command not found: 5.2

So I tried to see the available list of appraisals by running:

bundle exec appraisal list

And this is what I got:

rails_4_2
rails_5_0
rails_5_1
rails_5_2
rails_6_0

Then I replaced the 5.2 with rails_5_2 and the command worked.

@vsppedro
Copy link
Collaborator Author

vsppedro commented Nov 19, 2019

Should I start the Travis CI again? I only updated the CONTRIBUTING.md file.

The problem:

1) Shoulda::Matchers::ActiveRecord::ValidateUniquenessOfMatcher when the model has a scoped uniqueness validation when one of the scoped attributes is an integer column when more than one record exists that has the next version of the attribute's value accepts

     Failure/Error: expect(record).to validate_uniqueness.scoped_to(:scope)

     

       Expected Example to validate that :attr is case-sensitively unique

       within the scope of :scope, but this could not be proved.

         Given an existing Example, after setting its :attr to ‹"dummy value"›,

         then making a new Example and setting its :attr to ‹"dummy value"› as

         well and its :scope to a different value, ‹nil›, the matcher expected

         the new Example to be invalid, but it was valid instead.

     Shared Example Group: "it supports scoped attributes of a certain type" called from ./spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb:761

     # ./spec/unit/shoulda/matchers/active_record/validate_uniqueness_of_matcher_spec.rb:64:in `block (4 levels) in <top (required)>'

@guialbuk
Copy link
Collaborator

I ran just the failing build again. Everything is fine now.
Thank you for your contribution 🎉

@guialbuk guialbuk merged commit b902a53 into thoughtbot:master Nov 19, 2019
@vsppedro vsppedro deleted the update-contributing branch November 19, 2019 11:46
@guialbuk guialbuk mentioned this pull request Dec 26, 2019
guialbuk added a commit that referenced this pull request Jan 9, 2020
### Features

* Add support for `optional: false` in `belongs_to` associations. ([#1237])
* Add support for associations with `inverse_of: false` and non-standard foreign key ([#1106])

### Bug fixes
* Fix typos in documentation of `allow_values` ([#1241])
* Fix appraisal command in CONTRIBUTING.md file ([#1253])

### Improvements
* Remove minitest reporters dependency ([#1251])
* Development dependency updates

[#1106]: #1106
[#1237]: #1237
[#1241]: #1241
[#1253]: #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants