Use warnings_logger instead of warnings_spy; fix stray warnings #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
use-warnings-logger
branch
from
e50fec3
to
2daa367
Compare
`warnings_spy` was a little library I wrote to report warnings that came up during test runs and fail the CI build. A while back I extracted it to `warnings_logger`, so the version that exists here is obsolete.
mcmire
force-pushed
the
use-warnings-logger
branch
from
1f47b5f
to
6a0e436
Compare
mcmire
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warnings_spywas a little library I wrote to report warnings that cameup during test runs and fail the CI build. A while back I extracted it
to
warnings_logger, so the version that exists here is obsolete.