Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active record's counter_cache support #311

Closed
wants to merge 1 commit into from

Conversation

fgrehm
Copy link
Contributor

@fgrehm fgrehm commented Jun 20, 2013

Sorry for the noise but it seems that GH didn't like the fact that I amended the submatcher changes I made after @drapergeek's feedback on #310 (comment) =/

@fgrehm fgrehm mentioned this pull request Jun 20, 2013
@drapergeek
Copy link
Contributor

👍 Looks good!

@mxie
Copy link
Contributor

mxie commented Jun 21, 2013

Thanks for this new addition! Your PR has been merged. ✨✨✨

@mxie mxie closed this Jun 21, 2013
@sadjow
Copy link

sadjow commented Jun 21, 2013

\o/ :+1:

@fgrehm
Copy link
Contributor Author

fgrehm commented Jun 21, 2013

@drapergeek @mxie tks for merging it so fast! can't wait for a new release ;)

@sadjow
Copy link

sadjow commented Jun 21, 2013

+1 for the release!

@SabretWoW
Copy link

Has this been released into master yet? I downloaded the latest version and I'm still getting an 'undefined method counter_cache' error. Eager to try this out!

@mxie
Copy link
Contributor

mxie commented Aug 14, 2013

@kyletcarlson Yes, it has already been merged to master, but it hasn't been released as a new version. You can directly point to the master branch in your Gemfile if you would like to use this feature. Let us know if you're still having issues.

@SabretWoW
Copy link

@mxie Wonder why Bundler didn't pick that one up. Pointed my gemfile to master and it worked like a charm. Thanks for the quick reply :)

@mxie
Copy link
Contributor

mxie commented Aug 14, 2013

Awesome! And no problem! Glad I could be of help. :)

On Wednesday, August 14, 2013 at 1:30 PM, Kyle wrote:

@mxie (https://github.com/mxie) Wonder why Bundler didn't pick that one up. Pointed my gemfile to master and it worked like a charm. Thanks for the quick reply :)


Reply to this email directly or view it on GitHub (#311 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants