Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context support #313

Merged
merged 1 commit into from
Jul 12, 2013
Merged

Fix context support #313

merged 1 commit into from
Jul 12, 2013

Conversation

sj26
Copy link
Contributor

@sj26 sj26 commented Jul 2, 2013

Initially context support was developed back for shoulda matchers 1.x. When porting it forwards, the spec coverage was not sufficient to indicate that disallowed values and validation matchers did not support setting context, quickly revealed when I upgraded shoulda matchers in our codebase.

This patch specs and fixes context support for disallowed values and validation matchers.

@mxie mxie merged commit e40f778 into thoughtbot:master Jul 12, 2013
@mxie
Copy link
Contributor

mxie commented Jul 12, 2013

All merged in - thanks for putting in this pull request!

@sj26 sj26 deleted the fix-context branch July 13, 2013 02:34
@sj26 sj26 restored the fix-context branch July 13, 2013 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants