Add UUID support to validates_uniqueness_of matcher #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| context 'with an existing record that conflicts with scope.next' do |
There was a problem hiding this comment.
This context shares the same name with a context above. It looks like you copied this from the datetime context, which erroneously duplicates this context. Do you think you can remove this? I'll take care of removing the other one.
There was a problem hiding this comment.
Actually I will just go ahead and take care of removing this for you. Everything else looks fine.
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PostgreSQL is very strict in regard to column types validates_uniqueness_of needs to support :uuid as a column type to generate a valid test value. This pull request adds the necessary column type detection and respective tests.