-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refering ticket #70 #71
Conversation
@@ -48,23 +55,38 @@ def with_high_message(message) | |||
end | |||
|
|||
def description | |||
"ensure inclusion of #{@attribute} in #{@range.inspect}" | |||
@our_value = @range.nil? ? @array.inspect : @range.inspect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this logic to a method.
Admittedly some of my comments above are sort of nitpicky style stuff. |
i will fix all of those issues, but not friday night :-)) |
@gabebw I think its everything there :-) |
+1, I was going to fork this and create a pull request, although i couldn't have done a better job than this methinks. Can we expect this feature in a forthcoming new release some time soon? Thanks. |
hi @gabebw everything fine with my commits? I did see that you did try it in a unstable branch.. will you merge it or there is any other missing point? |
@vpereira: Thanks! I fixed one thing (the |
\o/ |
It's more like a proof of concept but it works.
now you can do something like:
we could implement as well the ensure_exclusion_of_matcher(:attr).in_array []