Allow the use of matchers from multiple libs, for non rails projects. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| subject { run_rspec_suite } | ||
|
|
||
| context 'in a project that uses both active_record and active_model libraries' do |
|
Ah. Yes -- this totally makes sense and I don't know why I overlooked this when I was adding this. |
lucasdavila
force-pushed
the
integrate-with-multiple-libs
branch
from
3bc9087
to
ffff82a
Compare
| expect(subject).to have_output('2 examples, 0 failures') | ||
| expect(subject).to have_output('should require name to be set') | ||
| expect(subject).to have_output( | ||
| 'should require case sensitive unique value for name' |
There was a problem hiding this comment.
Indent the first parameter one step more than the previous line.
lucasdavila
force-pushed
the
integrate-with-multiple-libs
branch
from
ffff82a
to
3d99399
Compare
|
@mcmire great, I just fixed the 🐶's review. |
| @@ -58,8 +59,8 @@ def no_test_frameworks_added? | |||
| @test_frameworks.empty? || !@test_frameworks.any?(&:present?) | |||
| end | |||
|
|
|||
| def library_not_set? | |||
| @library.nil? | |||
| def libraries_empty? | |||
There was a problem hiding this comment.
How about no_libraries_set?
There was a problem hiding this comment.
Oh yeah, it makes sense like no_test_frameworks_added?. I will rename it.
* It changes shoulda-matchers to allow the integration with multiple libraries like active_model and active_record. For example, in a non Rails project isn't possible to use both validate_presence_of and validate_uniqueness_of matchers, because they are from different libraries (one from active_model and the other from active_record respectively). This change allow the integration with multiple libraries. fixes thoughtbot#710
lucasdavila
force-pushed
the
integrate-with-multiple-libs
branch
from
3d99399
to
29e8eae
Compare
|
Thanks! This was merged as 721900b. |
|
@mcmire 👍 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes shoulda-matchers to allow the integration with multiple
libraries like active_model and active_record.
For example, in a non Rails project isn't possible to use both
validate_presence_of and validate_uniqueness_of matchers, because they
are from different libraries (one from active_model and the another from
active_record respectively).
This change allow the integration with multiple libraries.
fixes Undefined method validate_uniqueness_of error on sinatra app #710