Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run formatter documentation when running a single file #733

Merged
merged 1 commit into from Sep 22, 2015

Conversation

maurogeorge
Copy link
Contributor

Today if we run a single file or spec like callback_matcher_spec.rb or callback_matcher_spec.rb:12 the formatter is the default dot.

With this config when we run a single file or spec the formatter is the documentation and when we run the suite the formatter is the default dot.

I think this is good when we are working since we have the documentation output when we are doing the TDD and the regular formatter on running all suite.

Today if we run a single file or spec like `callback_matcher_spec.rb` or
`callback_matcher_spec.rb:12` the formatter is the default dot.

With this config when we run a single file or spec the formatter is the
documentation and when we run the suite the formatter is the default dot.
@mcmire
Copy link
Collaborator

mcmire commented Jun 15, 2015

This is a good idea. What about making it so that it's the default formatter regardless of how many files you're running? Also I'm wondering if it'd be good to add this to the integration_spec_helper too?

@maurogeorge
Copy link
Contributor Author

I agree on adding this on the integration_spec_helper.

About the doc formatter when running more than one file I personally don't like because you see a lot of output that is impossible to read, since this will be scrolling in the window.

But if you prefer I can update to this.

@mcmire mcmire merged commit c14f344 into thoughtbot:master Sep 22, 2015
@mcmire
Copy link
Collaborator

mcmire commented Sep 22, 2015

Thanks! What you have works for me.

@maurogeorge
Copy link
Contributor Author

Thanks for the merge @mcmire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants