Enhance AllowValueMatcher to take multiple arguments #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the deprecation of "should_allow_values_for" there is currently no clean way to specify multiple allowed (or forbidden) values for an attribute in a single assertion. This can make test cases unnecessarily verbose. This patch gives AllowValueMatcher the ability to take multiple values. The new matcher is fully downward compatible (i.e. given a single argument it behaves identically to the old matcher). This matcher will stop checking for bad values when the first bad value is encountered.
…to shoulda-matchers In this merge, we also adjust the spec to RSpec syntax. Conflicts: spec/shoulda/active_model/allow_value_matcher_spec.rb
|
This was a pull request to the old (now meta-) repository "shoulda". The merge commit contains the adjustments that were necessary (all in the test suite, the patch itself applied cleanly). |
| @expected_message ? (errors_match_regexp? || errors_match_string?) : (@errors.compact.any?) | ||
| if ! @instance.valid? | ||
| @errors = errors_for_attribute(@instance, @attribute) | ||
| @errors = [@errors] unless @errors.is_a?(Array) |
There was a problem hiding this comment.
A cleaner way to do this is to do @errors = Array.wrap(@errors).
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the deprecation of "should_allow_values_for", specifying multiple good (or bad) values has become quite noisy (array literal + iterator or roll-your-own macro).
Since it is completely downward compatible, I've enhanced the matcher with the ability to take multiple value arguments.