primary_key_name is deprecated in Rails 3.1

[joelmoss]

primary_key_name is deprecated in Rails 3 and shouts warnings in 3.1. Replaced with foreign_key

[omarqureshi]

Would it be better to see whether the Rails Version was actually 3.1? - that way it would still work for 3.0

i.e.

      if defined?(Rails) && Rails::VERSION::MAJOR >= 3 && Rails::VERSION::MINOR >= 1
        reflection.foreign_key
      else
        reflection.primary_key_name
      end

[joelmoss]

@omarqureshi Should be good to go now, thx.

[plentz]

+1

[haines]

Definitely keen for a fix for these warnings.

Rather than test the Rails version, why not

def foreign_key
  if reflection.respond_to?(:foreign_key)
    reflection.foreign_key
  else
    reflection.primary_key_name
  end
end

(or even a one-liner using ? :)

[omarqureshi]

even better!

[jasonm]

Deprec reference: https://github.com/rails/rails/blob/v3.1.0.beta1/activerecord/lib/active_record/reflection.rb#L201-208

[jasonm]

Thanks, all.

Merged in with commit 6b4035c