Lint JavaScript with eslint/prettier #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-fix-deprecated-rules
branch
2 times, most recently
from
4e4b000
to
5e48f43
Compare
This uses `@thoughtbot/eslint-config/base`, along with the `prettier` plugin and configuration for formatting and fixing. One rule is overidden, as using modules is nice in the tests, but this avoids changing the existing `index.js`.
nickcharlton
force-pushed
the
nc-lint-with-eslint-prettier
branch
from
96b4414
to
1810141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
@thoughtbot/eslint-config/base, along with theprettierplugin and configuration for formatting and fixing.One rule is overidden, as using modules is nice in the tests, but this avoids changing the existing
index.js.