Remove redux persist #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redux persist isn't needed. It was included originally to handle the case of a direct visit or back button visit to a page that had the redux store mutated from the original injected state. But I realized I could just lean on the [cache header] support from rails to handle freshness and force the browser to give us a new page, with the newly injected JSON too. [cache header]: https://thoughtbot.com/blog/take-control-of-your-http-caching-in-rails
whitecl
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux persist isn't needed. It was included originally to handle the case of a
direct visit or back button visit to a page that had the redux store mutated
from the original injected state.
But I realized I could just lean on the cache header support from rails to
handle freshness and force the browser to give us a new page, with the newly
injected JSON too.