Add type annotations to lib utils url #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #75
jho406
force-pushed
the
add-type-annotations-to-lib-utils-url
branch
from
21401c4
to
94dfd9d
Compare
jho406
added a commit
that referenced
this pull request
Jul 2, 2024
* Add type annotations for the reducers and state (#84) Incremental typing. I'm sure not everything is correct, but it'll improve as we type other parts of superglue. For now, i'm keeping close parity with what outputted to /dist, which is why you continue to see defaults on reducers. * Add action types (#85) * Add type annotations to utils/url (#87) Resolves #75 * Add remote and visit type annotations (#86) This adds remote and visit type annotations. `npm run type-check` doesn't pass yet, but the output to dist is still acceptable. Its a step in the right direction. * Update UJS type annotations * Prettier * Add type annotations to index.tsx * Add types to middleware * Add types to utils/request.ts * Add types to Nav.tsx * Add types to superglue index * Update type annotations on action creators * Add typing to update fragment actions * Prettier and update Error * Add typing for url parse * Remove any from data * Add content type * Remove Anys * Add type annotations to immutability * Revert removal of buildstore * Disable eslint * Maintain backward compatibility while preparing for redux toolkit * Fix specs * Remove babel proptypes * Remove any action * Fix depedencies * Remove extraneous pagekey setting * Use abstract classes * Use Record * Ensure override of url params when using form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type annotations to utils/url
Resolves #75