-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant Capybara config #1128
Remove redundant Capybara config #1128
Conversation
Capybara was configured to silence Puma in thoughtbot#981 to prevent Puma startup messages being output when running specs with `js: true`. This configuration has since been updated in [rspec-rails](rspec/rspec-rails#2289), so we can remove it here.
@cpjmcquillan thank you for opening this, and for linking to the relevant references. I cloned this branch locally, and spun up a system test, but was surprised to see it's still printing the Puma output.
Are you able to replicate the same behavior locally, too? For context, I ran I can see in the generated |
@stevepolitodesign classic me 😂. Thanks, let me dig into this 👍🏼 |
Hey @stevepolitodesign, I haven't been able to reproduce what you describe unfortunately 😢 I'm not sure what's going on, but give me a shout if you want to pair on this some time 👍 I did an experiment of sorts:
# spec/system/test_spec.rb
require "rails_helper"
RSpec.describe "Test", type: :system, js: true do
it "works!" do
visit page_path("test")
expect(page).to have_content("Hello, world!")
end
end <%# app/views/pages/test.html.erb %>
Hello, world
Capybara.server = :puma, {Silent: false}
|
@cpjmcquillan I'm not sure what was the issue on my end, but I just regenerated a new app from this branch, and I did not see the Puma output in the console 🎉 |
Capybara was configured to silence Puma in #981 to prevent Puma
startup messages being output when running specs with
js: true
.This configuration has since been updated in rspec-rails, so we can
remove it here.