Require spec/support files in alphabetical order #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the `require` order is the same on all machines, including CI. For example, we mainly use OS X as our local development machines, while CI runs on Linux. We've run into ordering issues before due to the different OS's, and this changes has historically fixed it.
|
👍 |
1 similar comment
|
👍 |
|
@tute Are you the leader of suspenders now? Is your thumbs up the final thumbs up? |
|
Yes Gabe. In my non-thoughtbot OSS I rebase/merge them myself (should I here, or should I let you do it?). And, while I'm responsible for suspenders, we have the Experiments Trello board that Joe keeps in mind and I don't visit often, so my sign off here would be enough I'd say for this PR, but for others I ask for his thumbs up too, so we make sure it's the right step forward before merging. Feel free to merge this! |
|
I'll merge this RIGHT NOW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the
requireorder is the same on all machines, including CI.For example, we mainly use OS X as our local development machines, while CI runs
on Linux. We've run into ordering issues before due to the different OS's, and
this changes has historically fixed it.