Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Heroku trail #128

Closed
wants to merge 1 commit into from
Closed

Conversation

PeterChapman
Copy link

Added Heroku trail

"id": "4ddf1f9e13f214095eecdf45e5b7f8c8efb97314"
},
{
"title": "Read 'Professional Heroku Programming",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing '

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

@adarsh
Copy link
Contributor

adarsh commented May 29, 2013

@PeterChapman - I tried rakeing the new trail (checks JSON, links, etc) and it seems to be mis-formatted JSON.

Can you please try linting and fixing the syntax?

Thanks for the submission!

@PeterChapman
Copy link
Author

@adarsh Fixed. The URI validation still times out on me though the links all work.

@adarsh
Copy link
Contributor

adarsh commented May 29, 2013

@PeterChapman Why close this? I like this submission a lot.

Also I might be mistaken, but I'm not seeing a new fix commit here on GH and the branch still fails for me.

Reopening.

@adarsh adarsh reopened this May 29, 2013
@PeterChapman
Copy link
Author

Whoops, didn't mean to close.
I squashed the commits but the json is valid now. Where do you get a failure?

@adarsh
Copy link
Contributor

adarsh commented May 29, 2013

My fault - didn't rebase off of your changes.

Looks good - merging and thanks for the contribution!

@adarsh adarsh closed this May 29, 2013
@PeterChapman
Copy link
Author

@adarsh Awesome, thanks. When do we get to see it on learn.thoughtbot.com?

@croaky
Copy link
Contributor

croaky commented May 29, 2013

@PeterChapman We have a nightly script that runs and pulls in changes from the trail-map. It should display at http://learn.thoughtbot.com/heroku tomorrow.

@PeterChapman
Copy link
Author

@croaky still don't see it?

@croaky
Copy link
Contributor

croaky commented Jun 6, 2013

@PeterChapman Sorry for the trouble. We had a missing Heroku Scheduler task! :)

All set now: https://learn.thoughtbot.com/heroku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants