Unify video show views #1536
Merged
Unify video show views #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| context "when the user does not have access to the video" do | ||
| it "displays a video preview" do | ||
| video = build_stubbed(:video, preview_wistia_id: 'prev') |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
christoomey
force-pushed
the
cjt-unify-video-views
branch
from
10eded7
to
c3bac94
Compare
|
That is a lot of removed lines! Looks great to me. |
christoomey
force-pushed
the
cjt-unify-video-views
branch
from
baa0ace
to
fb3fdfe
Compare
Currently we have 2 show views for videos, show_for_visitors & show_for_subscribers. These views have a great deal of duplication, but have also drifted over time and are slightly different for incidental reasons, rather than consciously. This change unifies the 2 views making it much easier to understand and think about what a user will see based on the various circumstances under which the view might be rendered (guest vs sampler vs subscriber, trail vs weekly iteration, free sample vs full video vs preview).
christoomey
force-pushed
the
cjt-unify-video-views
branch
from
fb3fdfe
to
c42b6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have 2 show views for videos,
show_for_visitors&show_for_subscribers. These views have a great deal of duplication, but have also drifted over time and are slightly different for incidental reasons, rather than consciously.This change unifies the 2 views making it much easier to understand and think about what a user will see based on the various circumstances under which the view might be rendered (guest vs sampler vs subscriber, trail vs weekly iteration, free sample vs full video vs preview).