Produce relative paths consistently #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://stackoverflow.com/a/24463362/555384 There are cases where `@%` will produce both relative and absolute paths, this change will make the behavior consistent. More specifically, even if you open the initial file relatively, some plugins (like rails.vim) target the opening of related files (using :A from a model for example) absolutely. In this case `@%` will go from producing `spec/model/thing_spec.rb` to producing `/Users/jon/..../spec/model/thing_spec.rb`, simply because you used a feature of an unrelated plugin. The specific case this is breaking for me, is that when running specs in a VM, the relative path is key. Absolute paths referencing the host machine obviously will blow up when attempting to run in a VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://stackoverflow.com/a/24463362/555384
There are cases where
@%will produce both relative and absolutepaths, this change will make the behavior consistent.
More specifically, even if you open the initial file relatively, some plugins
(like rails.vim) target the opening of related files (using :A from a
model for example) absolutely. In this case
@%will go from producingspec/model/thing_spec.rbto producing/Users/jon/..../spec/model/thing_spec.rb, simply because you used afeature of an unrelated plugin.
The specific case this is breaking for me, is that when running specs in
a VM, the relative path is key. Absolute paths referencing the host
machine obviously will blow up when attempting to run in a VM.