Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this tool have threading for faster process? #27

Closed
cr4shcod3 opened this issue Jul 15, 2018 · 4 comments
Closed

Does this tool have threading for faster process? #27

cr4shcod3 opened this issue Jul 15, 2018 · 4 comments

Comments

@cr4shcod3
Copy link

cr4shcod3 commented Jul 15, 2018

I don't know if there's threading in this tool but it seems like the process is slow. Is it normal?

@ThoughtfulDev
Copy link
Owner

ThoughtfulDev commented Jul 15, 2018

No threading. Only one instance of FF is open at a time, since some processes depend on each other.

What seems slow?

@cr4shcod3
Copy link
Author

The process like finding image and the reverse image search part. I hope you can find a way to add threading or threading argument in argparse

@ThoughtfulDev
Copy link
Owner

The problem is that I use one list for storing the images and scraped links.

Using threading would mean that each thread would have its own list which have to be unified at the end (or one global list which has to be thread save).

Practically I doubt that using threads would speed up the process.
You can always try to implement threading. Pull requests are welcome 😃

(this text may have some spelling mistakes since I'm on mobile)

@cr4shcod3
Copy link
Author

Ok I will try to implement threading on this. Later after I publish the v2 of my tool too. You can now close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants