Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for generating keypair from a seed #7

Closed

Conversation

mithrandi
Copy link
Contributor

I ended up using the libsodium version of this function, added here.

A few comments:

  1. I added this in two commits, one for the underlying C function, and one for the bindings. Let me know if you want me to squash these into one.
  2. I didn't add a test because... well, I'm not really sure how to test this (also I can't run the tests at the moment, but the other two pull requests open at the moment fix this). If you can think of something, I'd be happy to try implement it.

Signed-off-by: Tristan Seligmann <mithrandi@mithrandi.net>
mithrandi added a commit to mithrandi/hs-ed25519 that referenced this pull request Dec 15, 2014
Fixes thoughtpolice#7.

Signed-off-by: Tristan Seligmann <mithrandi@mithrandi.net>
@mithrandi
Copy link
Contributor Author

Oops, had the wrong bug number for some reason; fixed the reference in the commit message.

Fixes thoughtpolice#6.

Signed-off-by: Tristan Seligmann <mithrandi@mithrandi.net>
@thoughtpolice
Copy link
Owner

Thanks. I want to review this manually first (Since I think libsodium's ed25519 may be slightly different; there are a few 'ed25519 key formats' floating around in some places I think, an unfortunate side effect of no real standard.) Clipping the C code out is fine, and keeping it in a separate commit is as well.

@thoughtpolice
Copy link
Owner

Oh, nevermind. I was thinking of the actual format of output messages, not keys themselves. Yep, this looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants