-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allows loading a local csv file #176
Conversation
- modify the Dockerfile to reflect the new configuration - add a sheets directory with a sample sheet from the radar (based on the fix from thoughtworks#151)
in the local host
Very nice PR! Helped me a lot to get the project started locally and not wasting time to setup local file upload. Keep in mind to change the volume mount path according to your setup. I put in directly into the $ ... -v $pwd/src/sheets/:/opt/build-your-own-radar/sheets ... |
very good! It will help a lot. @dcasati |
Hi @dcasati whenI used this url in chrome, it use to just dl's the .csv and didnt render any JS. Now it renders just the csv no radar. Any tips? I used /tmp/sheets instead of your /mnt/radar/sheets/
http://localhost:8080/sheets/sheet.csv just renders the csv in the browser, no radar is displayed. Any tips? |
@lulubobst Not sure if you figured it out. However, just for posterity. You should not put the URL in your browser address bar. Instead http://localhost:8080/sheets/sheet.csv needs to be put in the "Enter the URL of your Google Sheet or CSV file below…" text box. After this, upon clicking "Build my radar" generates the radar without any errors. @dcasati Thanks a lot. Best fork out there for this repo! |
Hey @dcasati , this is still open to merge? Any idea why your changes hasn't been merged yet? |
Hi @dcasati , |
The merge conflicts were resolved and the PR was merged |
On this PR -
/opt/bring-your-own-radar/sheets/radar.csv
This should address common scenarios as described on #163 , #159, #133
For a quick test while an official docker image isn't in place:
This will:
/mnt/radar/sheets/
into the container on/opt/build-your-own-radar/sheets/
.You can now work locally on your machine, updating the csv file, rendering the result back on your browser.