Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Contributor guidelines #36

Closed
2 of 3 tasks
jmmercadom opened this issue Sep 30, 2013 · 2 comments · Fixed by #85
Closed
2 of 3 tasks

Contributor guidelines #36

jmmercadom opened this issue Sep 30, 2013 · 2 comments · Fixed by #85

Comments

@jmmercadom
Copy link
Contributor

Please contribute and update the todo list with your ideas

As a Pacto contributor
I want to contribute following some guidelines
So I can participate more effectively in the project

It was previously discussed that we need some guidelines for contributors so everybody proposes ways to contribute and agrees. We have to take more actions about this like on #28 that was a starting point to have a more consistent codebase,

These is a initial list of things to be addressed:

  • Create a page on the project that explains the best way to contribute on the project
  • Have a guideline on the best way for us to write specs
  • Have a guideline on the best way for us to write production code
jmmercadom added a commit that referenced this issue Sep 30, 2013
- Remove the word should from the spec names
- Add a gem that will prevent to this happen again
jmmercadom added a commit that referenced this issue Sep 30, 2013
- Replace all the should statements for expect
- Configure RSpec to use only expect assertions
@jmmercadom
Copy link
Contributor Author

We could adopt the guideline for testing http://betterspecs.org/. Also the PR #37 is following part of that guideline and is trying to bring more consistency to the specs.

@marcosccm
Copy link
Contributor

Great guide! We need to follow this steps on a clean environment to see if we really don't need anything else, but it looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants