This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Replace validator middlware stack with Cop plugins #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the validator middleware with a much better, more extensible "Cop" system.
A cop investigates that a request/response complies with a contract. A custom cop could also check for organizational conventions that are outside of the contract (e.g. security requirements). A cop issues citations. The
samples/cops.rb
code shows a custom cop:Obsoletes #91, because there is no more "body_only" feature. Instead, you can set the active cops to only include Pacto::Cops::RequestBodyCop and/or Pacto::Cops::ResponseBodyCop.
I am planning to rename rspec matchers and rake tasks to go with
investigate
rather thanvalidate
when it makes sense, but I'm going to do that as a separate PR since it is a bigger breaking change while this is (more) internal.