Fix Case of Arbitrary File Overwrite while scanning malicious repo (#225

)
thoughtworks · Aug 15, 2020 · 1fecebc · 1fecebc
1 parent f0917da
commit 1fecebc
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/report/report.go b/report/report.go
@@ -39,7 +39,9 @@ func GenerateReport(r *helpers.DetectionResults, directory string) (path string,
 			return "", fmt.Errorf("error copying reports: %v", err)
 		}
 	} else {
-		path = filepath.Join(directory, "talisman_reports", "/data")
+		path = filepath.Join(directory, "talisman_reports")
+		_ = os.RemoveAll(path)
+		path = filepath.Join(path, "data")
 		jsonFilePath = filepath.Join(path, jsonFileName)
 	}