Improve code coverage

thoughtworks · Jun 24, 2021 · d7d3459 · d7d3459
1 parent 5500fa2
commit d7d3459
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/talismanrc/entry-point.go b/talismanrc/entry-point.go
@@ -72,12 +72,12 @@ func MakeWithFileIgnores(fileIgnoreConfigs []FileIgnoreConfig) *persistedRC {
 }
 
 func BuildIgnoreConfig(mode Mode, filepath, checksum string, detectors []string) IgnoreConfig {
+	var result IgnoreConfig
 	switch mode {
 	case HookMode:
-		return &FileIgnoreConfig{FileName: filepath, Checksum: checksum, IgnoreDetectors: detectors}
+		result = &FileIgnoreConfig{FileName: filepath, Checksum: checksum, IgnoreDetectors: detectors}
 	case ScanMode:
-		return &ScanFileIgnoreConfig{FileName: filepath, Checksums: []string{checksum}, IgnoreDetectors: detectors}
-	default:
-		return &FileIgnoreConfig{FileName: filepath, Checksum: checksum, IgnoreDetectors: detectors}
+		result = &ScanFileIgnoreConfig{FileName: filepath, Checksums: []string{checksum}, IgnoreDetectors: detectors}
 	}
+	return result
 }
diff --git a/talismanrc/talismanrc_test.go b/talismanrc/talismanrc_test.go
@@ -83,6 +83,22 @@ func TestIgnoringDetectors(t *testing.T) {
 	assertAcceptsDetector("foo", "someDetector", "foo", "someOtherDetector", t)
 }
 
+func TestMakeWithFileIgnores(t *testing.T) {
+	ignoreConfigs := []FileIgnoreConfig{}
+	builtConfig := MakeWithFileIgnores(ignoreConfigs)
+	assert.Equal(t, builtConfig.FileIgnoreConfig, ignoreConfigs)
+	assert.Equal(t, builtConfig.Version, DefaultRCVersion)
+}
+
+func TestBuildIgnoreConfig(t *testing.T) {
+	var ignoreConfig IgnoreConfig
+	ignoreConfig = BuildIgnoreConfig(HookMode, "filename", "asdfasdfasdfasdfasdf", nil)
+	assert.IsType(t, &FileIgnoreConfig{}, ignoreConfig)
+
+	ignoreConfig = BuildIgnoreConfig(ScanMode, "filename", "asdfasdfasdfasdfasdf", nil)
+	assert.IsType(t, &ScanFileIgnoreConfig{}, ignoreConfig)
+}
+
 func TestAddIgnoreFiles(t *testing.T) {
 	talismanRCConfig := CreateTalismanRCWithScopeIgnores([]string{})
 	fileIgnoreConfig := &FileIgnoreConfig{