Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit as an option for single-repo installation #170

Closed
sradnev opened this issue Nov 6, 2019 · 5 comments
Closed

Add pre-commit as an option for single-repo installation #170

sradnev opened this issue Nov 6, 2019 · 5 comments

Comments

@sradnev
Copy link

sradnev commented Nov 6, 2019

We want to enforce talisman for specific repositories, potentially as a part of setup/build scripts. Currently the install.sh script is hardcoded as a pre-push hook.

We would like to be able to easily install talisman (e.g. via an install script) for specific repositories but as a pre-commit hook. Ideally, the install.sh script should be able to take a parameter just like the global install does.

We've considered adding a custom wrapper or a custom pre-commit hook that executes the talisman binary with the correct parameters but ideally we would like to avoid having to maintain anything like that on our own.

@sradnev
Copy link
Author

sradnev commented Nov 6, 2019

I'd be happy to add a pull request for this if people agree it is a desired feature?

@harinee
Copy link
Collaborator

harinee commented Nov 8, 2019

@sradnev
Copy link
Author

sradnev commented Nov 8, 2019

Yes, that section of the README refers to the install.sh script I meant. It has pre-push hardcoded: https://github.com/thoughtworks/talisman/blob/master/install.sh#L13

@salecharohit
Copy link

I would also like to have this feature. By default for per-project it adds a Pre-Push hook.

@dineshba
Copy link
Collaborator

dineshba commented Dec 9, 2019

@sradnev It looks like a desired feature. Please feel free to raise a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants