Modified the scan logic for pre-commit hooks #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest changes.
…o thoughtworks-master # Conflicts: # detector/detection_results.go # detector/filecontent_detector.go # detector/pattern_detector.go # runner.go
Resolved conflicts and Updated to latest changes.
… html reports when scanner is used.
This commit adds the below functionalities: - Generate scan report in JSON format, to be stored in report.json file. - Ask user for the directory where the reports need to be stored
Adds functionality to generate scan report in JSON format (thoughtworks#104)
The scan logic has now been updated to scan only the diff for each file if Talisman is being used as a pre-commit hook. For pre-push hook and scan functionalities, Talisman will continue to scan the whole file.
| } | ||
|
|
||
| log.WithFields(log.Fields{ | ||
| "additions": result, |
There was a problem hiding this comment.
Let's try and make logging of result less verbose.
We can
- Make this a debug log instead of info
or - Make sure the member Data []byte of type Addition is not logged by default
The scan logic has now been updated to scan only the diff for each file if Talisman is being used as a pre-commit hook. For pre-push hook and scan functionalities, Talisman will continue to scan the whole file. Fixed build failure
Stops the scan in scenarios where the checksum is matching
Pulling master changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan logic has now been updated to scan only the diff for each file if Talisman is being used as a pre-commit hook.
For pre-push hook and scan functionalities, Talisman will continue to scan the whole file.