Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: IntelliJ IDEA Scope #135

Closed
wants to merge 3 commits into from

Conversation

rflaperuta
Copy link

  • Feature, adding scope for IntelliJ Idea directory.

@svishwanath-tw
Copy link
Collaborator

Hi @rflaperuta

As PR's go this is one of the finest i've seen so far.
The code changes look good to me.

I'm concerned about the practice of checking in .idea folders into the repo.
One could end up putting sensitive information (file system paths, sensitive data that could be used as part of app configurations). Given this background, I think talisman shouldn't ignore .idea/** files permanently. What do you think ?

@rflaperuta
Copy link
Author

Hello, thanks for the feedback.

If the concern is misconfiguration leading to a leak, I agree with you.

On that matter would we need to revise exclusios for GO projects? I understand that there are some files that fall under your argument.

@svishwanath-tw
Copy link
Collaborator

@rflaperuta Sure thing, do mention them, we will take immediate action.

@rflaperuta
Copy link
Author

Just take a look at the file exclusions already configured in talisman....

@rflaperuta rflaperuta closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants